Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new data health signal page #6621

Merged
merged 30 commits into from
Dec 18, 2024
Merged

add new data health signal page #6621

merged 30 commits into from
Dec 18, 2024

Conversation

@mirnawong1 mirnawong1 requested a review from a team as a code owner December 9, 2024 14:51
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview Dec 18, 2024 6:26pm

@github-actions github-actions bot added content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address labels Dec 9, 2024

| **Health state** | **Criteria** |
|-------------------|---------------|
| ✅ Healthy | - Underlying sources are fresh AND<br />- Underlying models built successfully AND<br />- Underlying models’ tests passing AND<br />- (TBD) Underlying models built in the last 30 days |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these still TBD?
Screenshot 2024-12-09 at 15 10 09

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me check!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is still TBD. This can be added in once META-4025 is done


</TabItem>

<TabItem value="source-collection" label="Source collection health">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rpourzand @jcserv - what does 'source collection health' mean here and what's the diff between this and sources?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is just specific to sources?

Copy link
Contributor

@rpourzand rpourzand Dec 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source collections represent multiple sources, all mapping to different tables. We aggregate the information across the source.

@jcserv we don't actually show source collection health signal so I wonder if we even need this yet? We should file a backlog task to show this in the app though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this should not be added to the docs yet until META-3973/3971 are completed


The health state of a source collection is determined by the following criteria:

Functions as an aggregate of underlying sources
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does this mean?

Functions as an aggregate of underlying sources

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we did show it, we are essentially just aggregating all the respective sources in the source collection


Access data health signals in the following places:
- In the [search function](/docs/collaborate/explore-projects#search-resources) or under **Models**, **Sources**, or **Exposures** in the **Resource** tab.
- For sources, the data health signal also indicates the source freshness status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

This is a non-blocker suggestion / Would it be good to link out source freshness to a source freshness page: https://docs.getdbt.com/docs/deploy/source-freshness or https://docs.getdbt.com/docs/build/sources#snapshotting-source-data-freshness

Kind Regards
Natalie

Copy link
Contributor

@nataliefiann nataliefiann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hiya @mirnawong1

Thanks for creating this. I've approved this for you and left 2 non-blocking suggestions.

Kind Regards
Natalie

natalie's feedback
@runleonarun runleonarun enabled auto-merge (squash) December 18, 2024 18:23
@runleonarun runleonarun merged commit bea1115 into current Dec 18, 2024
8 checks passed
@runleonarun runleonarun deleted the update-trust-signals branch December 18, 2024 18:26
Copy link
Contributor

Check your created Crawler

Check your created index on your Algolia Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs size: medium This change will take up to a week to address trigger-crawl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants