-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new data health signal page #6621
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…t.com into update-trust-signals
|
||
| **Health state** | **Criteria** | | ||
|-------------------|---------------| | ||
| ✅ Healthy | - Underlying sources are fresh AND<br />- Underlying models built successfully AND<br />- Underlying models’ tests passing AND<br />- (TBD) Underlying models built in the last 30 days | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is still TBD. This can be added in once META-4025 is done
|
||
</TabItem> | ||
|
||
<TabItem value="source-collection" label="Source collection health"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rpourzand @jcserv - what does 'source collection health' mean here and what's the diff between this and sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is just specific to sources?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source collections represent multiple sources, all mapping to different tables. We aggregate the information across the source.
@jcserv we don't actually show source collection health signal so I wonder if we even need this yet? We should file a backlog task to show this in the app though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this should not be added to the docs yet until META-3973/3971 are completed
|
||
The health state of a source collection is determined by the following criteria: | ||
|
||
Functions as an aggregate of underlying sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does this mean?
Functions as an aggregate of underlying sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we did show it, we are essentially just aggregating all the respective sources in the source collection
|
||
Access data health signals in the following places: | ||
- In the [search function](/docs/collaborate/explore-projects#search-resources) or under **Models**, **Sources**, or **Exposures** in the **Resource** tab. | ||
- For sources, the data health signal also indicates the source freshness status. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
This is a non-blocker suggestion / Would it be good to link out source freshness to a source freshness page: https://docs.getdbt.com/docs/deploy/source-freshness or https://docs.getdbt.com/docs/build/sources#snapshotting-source-data-freshness
Kind Regards
Natalie
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hiya @mirnawong1
Thanks for creating this. I've approved this for you and left 2 non-blocking suggestions.
Kind Regards
Natalie
natalie's feedback
Check your created Crawler Check your created index on your Algolia Application |
this pr adds a new page dedicated to new data health signals for dbt explorer
internal slack
🚀 Deployment available! Here are the direct links to the updated files: